The only traditionally accepted way to write the expression “all right” (meaning “acceptable, satisfactory”) is as two separate words. This seems counterintuitive, since the majority of expressions of the form “all + something”, where “all” is used to mean “in a general manner”, are spelled as a single word, for example,
One notable exception is “all-around”, which is spelled with a hyphen:
However, “all right” is never spelled with a hyphen. So, how should you write “all right + noun”, as in “he did an all right job?” The answer is: You shouldn’t. Using “all right” as an adjective before a noun is generally discouraged and considered somewhat acceptable only in colloquial speech, but not in writing.
Perhaps the following terrible pun will help you remember the correct spelling: